[Drbd-dev] Re: drbd uses wrong API for struct bio

[Jens Axboe]

On Sun, Jan 23 2005, Lars Marowsky-Bree wrote:
> Hi all,
> 
> drbd is a quite bad offender for using bio's on stack or embedded in
> other internal structs instead of the pointer interface.
> 
> The attached patch shows the 'right' way as an example, which was
> pretty easy because I could use Jens' patch for md with minimal
> modifications ;-) However, the other offending code lines are within
> the transfer log and other places, and I'm not sure Philipp wants me
> to mess around with that.

Patch looks fine, I'm sad to say that if drdb was just in the kernel
source this would have been found in time...

> Jens, on chip.suse.de:/local/lmb/drbd-07/drbd/ you can find the most
> recent drbd kernel code. Could you look over drbd_compat_wrappers.h
> line 326ff in particular and give me a rough rundown of what's broken?
> We need to fix this by Tuesday latest :-(

Sure, will do so this morning.

-- 
Jens Axboe