[Drbd-dev] Re: [DRBD-cvs] r1598 - trunk/user

[Lars Marowsky-Bree]

On 2004-10-19T09:32:24, svn at svn.drbd.org wrote:

> Author: phil
> Date: 2004-10-19 09:32:21 +0200 (Tue, 19 Oct 2004)
> New Revision: 1598
> 
> Modified:
>    trunk/user/Makefile
>    trunk/user/drbdmeta.c
> Log:
> [patch by LGE] 
>  * removed the dependency on glib, and use the kernel's
>    includes instead. 

Do not do that. Please. Including kernel-headers from user-space is an
absolute nightmare, it keeps breaking sporadically and in particular on
non-i386 archs. The kernel headers just aren't meant to be used in
user-space (and are documented to not be supported for this), and all
the build issues I've had with OCFS, Lustre, ... have been caused by
this.

In particular these headers

> +#include <asm/byteorder.h>	/* for the __cpu_to_le64 etc. functions  */
> +#include <linux/bitops.h>	/* for the hweight functions  */
> +#include <linux/types.h>	/* for the __u32/64 type defs */

_are known to break_ on ia64/ppc64/s390x. I'd be very grateful if you
could avoid this.


Sincerely,
    Lars Marowsky-Brée <lmb at suse.de>

-- 
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX AG - A Novell company