[Drbd-dev] drbd-latest introduces new build dependency on subversion

[Lars Ellenberg]

/ 2004-08-16 14:02:02 +0200
\ Lars Marowsky-Bree:
> On 2004-08-04T15:41:47,
>    Lars Ellenberg <Lars.Ellenberg@linbit.com> said:
> 
> > .filelist is only removed by distclean, so that should work.
> > I just now did a successfull "make rpm" in a tar xvzf drbd-0.7.1.tgz.
> > 
> > now, does it work for you again?
> 
> I don't use make rpm; I our buildsystem gets the source files + a spec
> file to build everything from, but for various reasons build from svn
> sources.
> 
> Now as the drbd specfile also generates the km_drbd package which holds
> the external module which is needed to build the kernel, this means that
> I try to keep the dependency chain short. Introducing subversion meant
> that essentially the kernel got build after subversion->drbd, which
> wasn't good. I've now replaced the call to svnversion with a perl one
> liner to grab it from the .svn/dir-wcprops file. ;)

which is the same only for the special case
of an unmodified svn checkout.

> 
> Maybe I really should generate the source tarball for building using
> make tgz though instead of simply tarring the svn dir up...

if you do so, please use "make tarball".
make tgz lacks some preparation steps...

tarball additionally makes sure that there are no modifications pending,
that the changelogs are up-to-date, that documentation is build (ok, *you*
won't need that in the tarball), the .filelist is regenerated, and then
calls make tgz, which just generates the tgz.

tarring up the .svn working dir should work the same, too.
you'd need to "make drbd/drbd_buildtag.c" before you tar it,
and you apply this patch with the preparation step in your
drbd.spec:


--- Makefile	(revision 1490)
+++ Makefile	(working copy)
@@ -96,7 +96,7 @@
 # update of drbd_buildtag.c is forced:
 .PHONY: drbd/drbd_buildtag.c
 drbd/drbd_buildtag.c:
-	@is_tarball=`test -e .svn/. && echo false || echo true`;		\
+	@is_tarball=true;		\
 	set -e; exec > $@.new;							\
 	echo -e "/* automatically generated. DO NOT EDIT. */";			\
 	echo -e "const char * drbd_buildtag(void)\n{";			\