[DRBD-cvs] svn commit by lars - r2814 - in trunk: drbd user - some
comment fixes I did month ago but never comitted
drbd-cvs at lists.linbit.com
drbd-cvs at lists.linbit.com
Mon Mar 26 14:34:54 CEST 2007
Author: lars
Date: 2007-03-26 14:34:51 +0200 (Mon, 26 Mar 2007)
New Revision: 2814
Modified:
trunk/drbd/drbd_int.h
trunk/user/drbd_endian.h
Log:
some comment fixes I did month ago but never comitted
Modified: trunk/drbd/drbd_int.h
===================================================================
--- trunk/drbd/drbd_int.h 2007-03-26 12:30:52 UTC (rev 2813)
+++ trunk/drbd/drbd_int.h 2007-03-26 12:34:51 UTC (rev 2814)
@@ -420,8 +420,11 @@
/*
* commands which share a struct:
- * RecvAck (proto B), WriteAck (proto C) (see Drbd_BlockAck_Packet)
- * DataRequest, RSDataRequest (see Drbd_BlockRequest_Packet)
+ * Drbd_BlockAck_Packet:
+ * RecvAck (proto B), WriteAck (proto C),
+ * DiscardAck (proto C, two-primaries conflict detection)
+ * Drbd_BlockRequest_Packet:
+ * DataRequest, RSDataRequest
*/
typedef struct {
Drbd_Header head;
@@ -462,14 +465,10 @@
} __attribute((packed)) Drbd_HandShake_Packet;
// 80 bytes, FIXED for the next century
-/* FIXME do we actually send a barrier packet with "0" as barrier number?
- * what for?
- * couldn't we send the pointer as handle as well, as we do with block_id?
- */
typedef struct {
Drbd_Header head;
- u32 barrier; // may be 0 or a barrier number
- u32 pad; //make sure packet is a multiple of 8 Byte
+ u32 barrier; // barrier number _handle_ only
+ u32 pad; // make sure packet is a multiple of 8 Byte
} __attribute((packed)) Drbd_Barrier_Packet;
typedef struct {
Modified: trunk/user/drbd_endian.h
===================================================================
--- trunk/user/drbd_endian.h 2007-03-26 12:30:52 UTC (rev 2813)
+++ trunk/user/drbd_endian.h 2007-03-26 12:34:51 UTC (rev 2814)
@@ -29,7 +29,7 @@
/* linux/byteorder/swab.h */
-/* casts are necessary for constants, because we never know how for sure
+/* casts are necessary for constants, because we never know for sure
* how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way.
*/
More information about the drbd-cvs
mailing list