[DRBD-cvs] svn commit by lars - r2416 - trunk/drbd - disable seemingly wrong assert in drbd_bm_set_bits_in_i

drbd-cvs at lists.linbit.com drbd-cvs at lists.linbit.com
Wed Sep 13 15:50:35 CEST 2006


Author: lars
Date: 2006-09-13 15:50:34 +0200 (Wed, 13 Sep 2006)
New Revision: 2416

Modified:
   trunk/drbd/drbd_bitmap.c
Log:
disable seemingly wrong assert in drbd_bm_set_bits_in_irq

Modified: trunk/drbd/drbd_bitmap.c
===================================================================
--- trunk/drbd/drbd_bitmap.c	2006-09-13 13:32:11 UTC (rev 2415)
+++ trunk/drbd/drbd_bitmap.c	2006-09-13 13:50:34 UTC (rev 2416)
@@ -984,7 +984,13 @@
 	ERR_IF(!b) return 1;
 	ERR_IF(!b->bm) return 1;
 
+#if 0
+	/* hm. I assumed that, when inside of lock_irq/unlock_irq,
+	 * in_interrupt() would be true ?
+	 * how else can I assert that this called with irq disabled without using
+	 * spin_lock_irqsave? */
 	D_BUG_ON(!in_interrupt()); /* called within spin_lock_irq(&mdev->req_lock) */
+#endif
 
 	spin_lock(&b->bm_lock);
 	BM_PARANOIA_CHECK();



More information about the drbd-cvs mailing list