[DRBD-cvs] svn commit by lars - r2536 - trunk/drbd - does it help do move the drbd_plug after the submit?

[drbd-cvs at lists.linbit.com]

Author: lars
Date: 2006-10-16 18:30:03 +0200 (Mon, 16 Oct 2006)
New Revision: 2536

Modified:
   trunk/drbd/drbd_req.c
Log:
does it help do move the drbd_plug after the submit?

Modified: trunk/drbd/drbd_req.c
===================================================================
--- trunk/drbd/drbd_req.c	2006-10-16 15:58:00 UTC (rev 2535)
+++ trunk/drbd/drbd_req.c	2006-10-16 16:30:03 UTC (rev 2536)
@@ -829,10 +829,6 @@
 		goto fail_and_free_req;
 	}
 
-	/* we need to plug ALWAYS since we possibly need to kick lo_dev
-	 * FIXME I'd like to put this within the req_lock, too... */
-	drbd_plug_device(mdev);
-
 	/* For WRITE request, we have to make sure that we have an
 	 * unused_spare_barrier, in case we need to start a new epoch.
 	 * I try to be smart and avoid to pre-allocate always "just in case",
@@ -988,6 +984,11 @@
 		else
 			generic_make_request(req->private_bio);
 	}
+
+	/* we need to plug ALWAYS since we possibly need to kick lo_dev.
+	 * we plug after submit, so we won't miss an unplug event */
+	drbd_plug_device(mdev);
+
 	return 0;
 
   fail_and_free_req: