[Csync2] Re: csync2-1.32 gets "Too many open files" error

[Clifford Wolf]

Hi,

On Sat, Aug 05, 2006 at 09:17:41PM -0700, Mark Glines wrote:
> Nope, its a bug in csync2.  I had a little more time and isolated it: on
> the server (inetd) side, csync2_file_backup() never closes the fd_in
> *or* fd_out files, so it leaks two file handles per backup, when backups
> are enabled.

And the "csync2 patch of the year award" goes to.. Mark Glines !!

I've applied the patch (with some additional changes to also close the open
fds in all error cases) and released csync2 1.33.

Thanks a lot for your help.

yours,
 - clifford

--
/"\  ASCII Ribbon Campaign - against html email
\ /                        - against microsoft office attachments
 X                         - against text above fullquote below
/ \                        - against lines longer than 79 characters
 
"They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety."
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759