<div dir="ltr"><div>Hi drbd-user,</div><div><br></div>I have another patch for the same functionality. Please ignore previous patch. <div>diff --git a/user/v9/drbdadm_parser.c b/user/v9/drbdadm_parser.c<br>index 18019c0..c7d3616 100644<br>--- a/user/v9/drbdadm_parser.c<br>+++ b/user/v9/drbdadm_parser.c<br>@@ -720,7 +720,7 @@ static void __parse_address(struct d_address *a)<br>    a->port = yylval.txt;<br>    range_check(R_PORT, "port", yylval.txt);<br><br>-    a->is_local_address = addr_scope_local(a->addr);<br>+    a->is_local_address = addr_scope_local(a->addr) ? addr_scope_local(a->addr) : have_ip(a->af, a->addr);<br> }<br></div></div><div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2"><br> <table style="border-top:1px solid #d3d4de">
<tr>
<td style="width:55px;padding-top:18px"><a href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail" target="_blank"><img src="https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif" alt="" width="46" height="29" style="width: 46px; height: 29px;"></a></td>
<td style="width:470px;padding-top:17px;color:#41424e;font-size:13px;font-family:Arial,Helvetica,sans-serif;line-height:18px">ä¸å«ç—…毒。<a href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail" target="_blank" style="color:#4453ea">www.avast.com</a> </td>
</tr>
</table>
<a href="#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width="1" height="1"></a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">莊凱傑 <<a href="mailto:kcchuang.white@gmail.com">kcchuang.white@gmail.com</a>> æ–¼ 2019å¹´6月14æ—¥ 週五 下åˆ6:41寫é“：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi drbd-user,<div><br></div><div>I made some code changes for achieving local and remote replication at the same time. Any idea is appreciated.<br><div><br></div><div>Previously I sent a local replication problem email, actually I want to achieve the goal of drbd local replication with remote replication at the same time.</div><div>I look into the patch f0b6e32, in this patch drbdadm is designed allowing loopback ip(127.0.0.1) replication by skipping loopback ip check. Hence local replication is not a problem now.</div><div><br></div><div>I want to achieve local replication with remote replication at the same time. And the function <span class="gmail-m_-1132764415500555064gmail-m_7094562953561678107gmail-blob-code-inner"><span class="gmail-m_-1132764415500555064gmail-m_7094562953561678107gmail-pl-en">check_addr_conflict</span></span> still disallow the local host ip(except for 127.0.0.1) sharing. Hence I'm wondering if we can allow local other ip sharing as well as follows:</div><div>diff --git a/user/shared/shared_tool.c b/user/shared/shared_tool.c<br>index cdfe9e4..ca17b49 100644<br>--- a/user/shared/shared_tool.c<br>+++ b/user/shared/shared_tool.c<br>@@ -484,9 +484,15 @@ bool addr_scope_local(const char *input)<br>    struct in6_addr addr6;<br><br>    if (inet_pton(AF_INET6, input, &addr6) == 1)<br>-        return IN6_IS_ADDR_LOOPBACK(&addr6);<br>+       if (have_ip_ipv6(input) == 1)<br>+            return true;<br>+       else<br>+              return IN6_IS_ADDR_LOOPBACK(&addr6);<br>    else if (inet_pton(AF_INET, input, &addr4) == 1)<br>-        return IN_IS_ADDR_LOOPBACK(&addr4);<br>+       if (have_ip_ipv4(input) == 1)<br>+            return true;<br>+       else<br>+            return IN_IS_ADDR_LOOPBACK(&addr4);<br><br>    return false;<br> }<br></div><div><br></div><div>After the above changes, I hope the r0.res and r0-local.res(as attached) will be bought up successfully. As you can see in r0.res, I hope local and remote replication being bought up at the same time.</div></div><div><br></div>-- <br><div dir="ltr" class="gmail-m_-1132764415500555064gmail_signature"><div dir="ltr">è¬è¬<div>Kevin</div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">è¬è¬<div>Kevin</div></div></div>