<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
here the compile error with 8.3.3. I mentioned onl 8.3.3 because this
is the version mentioned in the documentation to support kernel 2.6.31
line.<br>
<br>
+++++++++++++ compile error +++++++++++++++<br>
CC [M] /root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.o<br>
/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.c: In function
â_drbd_start_io_acctâ:<br>
/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.c:64: error:
lvalue required as increment operand<br>
/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.c: In function
â_drbd_end_io_acctâ:<br>
/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.c:86: error:
lvalue required as decrement operand<br>
make[6]: *** [/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd/drbd_req.o]
Error 1<br>
make[5]: *** [_module_/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd]
Error 2<br>
make[4]: *** [sub-make] Error 2<br>
make[3]: *** [all] Error 2<br>
make[3]: Leaving directory `/usr/src/linux-2.6.31.1-3-obj/x86_64/xen'<br>
make[2]: *** [kbuild] Error 2<br>
make[2]: Leaving directory `/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3/drbd'<br>
make[1]: *** [module] Error 2<br>
make[1]: Leaving directory `/root/drbd-8.3.3/dist/BUILD/drbd-8.3.3'<br>
error: Bad exit status from /var/tmp/rpm-tmp.80087 (%build)<br>
+++++++++++++ compile error +++++++++++++++<br>
<br>
<br>
Jeroen Groenewegen van der Weyden wrote:
<blockquote cite="mid:4AC9EBEB.2000106@grosc.com" type="cite">
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<br>
the openSUSE xen kernel<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/x86_64/kernel-xen-devel-2.6.31.1-3.1.x86_64.rpm">http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/x86_64/kernel-xen-devel-2.6.31.1-3.1.x86_64.rpm</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/noarch/kernel-source-2.6.31.1-3.1.noarch.rpm">http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/noarch/kernel-source-2.6.31.1-3.1.noarch.rpm</a><br>
<br>
indeed the error also occures in 8.3.2 but I can confirm to you
8.3.3RC3 has the same probleem. <br>
<br>
mfg,<br>
<br>
jeroen<br>
<br>
Lars Ellenberg wrote:
<blockquote cite="mid:20091005120039.GD8038@barkeeper1-xen.linbit"
type="cite">
<pre wrap="">On Mon, Oct 05, 2009 at 01:21:07PM +0200, Jeroen Groenewegen van der Weyden wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello,
I tried to compile drbd 8.3.3RC against kernel source 2.6.31.1-3, I get
a compile error.
</pre>
</blockquote>
<pre wrap=""><!---->
uhm.
what exact kernel source is that?
distro? kernel.org?
Did you (or those guys responsible for your kernel source)
notice this upstream commit?
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0f78ab9899e9d6acb09d5465def618704255963b;hp=e00c54c36ac2024c3a8a37432e2e2698ff849594">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0f78ab9899e9d6acb09d5465def618704255963b;hp=e00c54c36ac2024c3a8a37432e2e2698ff849594</a>
</pre>
<blockquote type="cite">
<pre wrap="">Sources obtained from <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://oss.linbit.com/drbd/8.3/drbd-8.3.3rc3.tar.gz">http://oss.linbit.com/drbd/8.3/drbd-8.3.3rc3.tar.gz</a>
++++++++++ compile error +++++++++++
CC [M] /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o
</pre>
</blockquote>
<pre wrap=""><!----> ^^^^^^^^^^
you say its 8.3.3rc, yet it is in drbd-8.3.2?
</pre>
<blockquote type="cite">
<pre wrap="">/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function
â_drbd_start_io_acctâ:
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:64: error: lvalue
required as increment operand
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function
â_drbd_end_io_acctâ:
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:86: error: lvalue
required as decrement operand
make[6]: *** [/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o]
Error 1
make[5]: *** [_module_/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd] Error 2
make[4]: *** [sub-make] Error 2
make[3]: *** [all] Error 2
++++++++++ compile error +++++++++++
solution
based on this patch but only for lines 64 and 86
"diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index cbdc257..0656cf1 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -42,7 +42,7 @@ static void _drbd_start_io_acct(struct drbd_conf *mdev, struct drbd_request *req
part_stat_inc(cpu, &mdev->vdisk->part0, ios[rw]);
part_stat_add(cpu, &mdev->vdisk->part0, sectors[rw], bio_sectors(bio));
part_stat_unlock();
- mdev->vdisk->part0.in_flight++;
+ mdev->vdisk->part0.in_flight[rw]++;
}
</pre>
</blockquote>
<pre wrap=""><!---->
...
</pre>
</blockquote>
<br>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
drbd-user mailing list
<a class="moz-txt-link-abbreviated" href="mailto:drbd-user@lists.linbit.com">drbd-user@lists.linbit.com</a>
<a class="moz-txt-link-freetext" href="http://lists.linbit.com/mailman/listinfo/drbd-user">http://lists.linbit.com/mailman/listinfo/drbd-user</a>
</pre>
</blockquote>
<br>
</body>
</html>