[DRBD-user] [PATCH] drbd: Remove fix me statements

Nicholas Krause xerofoify at gmail.com
Tue Jul 22 20:19:21 CEST 2014

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.

This removes no longer needed fix me statements as the spinlocks
are needed to protect against other users of the list accessing
 it when items on it are being moved off it.

Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
 drivers/block/drbd/drbd_worker.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index d8f57b6..8793a32 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -1847,12 +1847,12 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 		int send_barrier;
 		prepare_to_wait(&connection->sender_work.q_wait, &wait, TASK_INTERRUPTIBLE);
-		spin_lock(&connection->sender_work.q_lock);	/* FIXME get rid of this one? */
+		spin_lock(&connection->sender_work.q_lock);
 		/* dequeue single item only,
 		 * we still use drbd_queue_work_front() in some places */
 		if (!list_empty(&connection->sender_work.q))
 			list_move(connection->sender_work.q.next, work_list);
-		spin_unlock(&connection->sender_work.q_lock);	/* FIXME get rid of this one? */
+		spin_unlock(&connection->sender_work.q_lock);
 		if (!list_empty(work_list) || signal_pending(current)) {

More information about the drbd-user mailing list