Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
On Wed, Oct 20, 2010 at 01:42:37PM +0200, rf at q-leap.de wrote: > >>>>> "Lars" == Lars Ellenberg <lars.ellenberg at linbit.com> writes: > > Lars> On Mon, Oct 18, 2010 at 12:47:14PM +0200, rf at q-leap.de wrote: > >> Also there were two issues when compiling the kernel modules for a 2.6.32 > >> kernel (both are present in 22.214.171.124 as well). I've appended a diff to > >> the patch file I generated using make kernel-patch. > > Lars> Works for me, though. > > Could you let me know what your exact cmdline to generate the patch is? > > Lars> The second chunk should be generated by the build automagic > Lars> anyways. > > Build automagic of who? The kernel? When I apply the patch generated by > make kernel-patch and compile I get a "BLK_MAX_SEGMENTS undefined" error. Ah. Well, the build magic of DRBD. You are supposed to build the out-of-tree DRBD module as external module. You are not supposed to use the "make kernel-patch" thing. It may or may not work. I don't really care if it does. We should probably drop if from our makefiles now. But if you go that route, you first need to ./scripts/adjust_drbd_config_h.sh Or even KDIR=$KDIR O=$O ../scripts/adjust_drbd_config_h.sh > Lars> Could you reason why the first chunk would be necessary? > > The kernel doesn't know about the variable $(DRBDSRC) Of course it does not. And you should not patch it in there. The in-kernel tree drbd must only use the in kernel tree .h files, obviously. So the in-kernel tree Makefile should be left untouched. -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed