[DRBD-user] drbd on virtio: WARNING: at block/blk-core.c

Stefan Hajnoczi stefanha at linux.vnet.ibm.com
Sun Nov 14 10:46:48 CET 2010


On Sat, Nov 13, 2010 at 11:32:47PM +0100, Lars Ellenberg wrote:
> On Sat, Nov 13, 2010 at 02:24:05PM +0000, Stefan Hajnoczi wrote:
> > Does this fix the issue?  Compiled but not tested.
> > 
> > Subject: [PATCH] drbd: Use irqsave/irqrestore for req_mod() in drbd_endio_pri()
> > 
> > It is not safe to call req_mod() from drbd_endio_pri() since it uses
> > spin_lock_irq()/spin_unlock_irq().  Instead use irqsave/irqrestore and
> > call __req_mod() so that local irq mode is preserved.
> 
> Right, thanks for your work.
> 
> See also my other post.
> 
> I previously only "fixed" req_mod(),
> wondering why that would show up only now.
> But then found the other commit that broke it, back in August, which
> contained a chunk that basically looks like your below patch, reversed
>   :(
> 
> So it's fixed in our internal git already,
> the fix should show up in public git early next week.

Great!

Stefan


More information about the drbd-user mailing list