[DRBD-user] [patch] drbd: cleanup: change "<= 0" to "== 0"

Philipp Reisner philipp.reisner at linbit.com
Mon Aug 23 18:03:22 CEST 2010


Am Montag, 23. August 2010, um 12:34:29 schrieb Jens Axboe:
> On 2010-08-12 00:38, Dan Carpenter wrote:
> > dt is unsigned so it's never less than zero.  We are calculating the
> > elapsed time, and that's never less than zero (unless there is a bug or
> > we invent time travel).  The comparison here is just to guard against
> > divide by zero bugs.
> > 
> > Signed-off-by: Dan Carpenter <error27 at gmail.com>
> > 
> > diff --git a/drivers/block/drbd/drbd_proc.c
> > b/drivers/block/drbd/drbd_proc.c index be3374b..4c0c4aa 100644
> > --- a/drivers/block/drbd/drbd_proc.c
> > +++ b/drivers/block/drbd/drbd_proc.c
> > @@ -118,7 +118,7 @@ static void drbd_syncer_progress(struct drbd_conf
> > *mdev, struct seq_file *seq)
> > 
> >  	/* mean speed since syncer started
> >  	
> >  	 * we do account for PausedSync periods */
> >  	
> >  	dt = (jiffies - mdev->rs_start - mdev->rs_paused) / HZ;
> > 
> > -	if (dt <= 0)
> > +	if (dt == 0)
> > 
> >  		dt = 1;
> >  	
> >  	db = mdev->rs_total - rs_left;
> >  	dbdt = Bit2KB(db/dt);
> 
> Lars et al, I'll let you pick this up.

Jens, we (LINBIT) feel responsible for picking this up. I work on that
tomorrow.

Best,
 Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.



More information about the drbd-user mailing list