[DRBD-user] Port "RPM building bug" fix to drbd 0.8

[Maxim Doucet]

Lars Ellenberg a écrit :
> On Wed, Jun 20, 2007 at 06:19:41PM +0200, Maxim Doucet wrote:
>   
>> According to this past discussion : "rpm building bug?"
>> (http://lists.linbit.com/pipermail/drbd-user/2007-January/006243.html),
>> the rpm bug still exists in 0.8.x version.
>>
>> The problem is basically that the script scripts/get_uts_release.sh
>> doesn't work if the KDIR variable is not exported.
>>
>> This has been fixed in the 0.7 branche (according to
>> http://lists.linbit.com/pipermail/drbd-user/2007-January/006243.html)
>> where the variable is exported into the Makefile. See
>> http://svn.drbd.org/drbd/branches/drbd-0.7/Makefile
>>
>> Though the fix is not present in the 0.8 branche's Makefile :
>> http://svn.drbd.org/drbd/branches/drbd-8.0/Makefile
>> Could this fix be port to the 0.8 branche ?
>>
>> The - little - patch is :
>>
>> ### PATCH-BEGIN
>> --- /root/drbd-8.0.3/Makefile   2007-05-07 17:18:50.000000000 +0200
>> +++ /usr/src/drbd-8.0.3/Makefile        2007-06-20 17:25:54.000000000 +0200
>> @@ -172,6 +172,7 @@
>>
>>  all tools doc .filelist: drbd/drbd_buildtag.c
>>
>> +export KDIR KVER 0
>>     
>                     ^ that should be the capital letter O, not a zero...
>   
Thanks for pointing this out
>>  KDIR := $(shell echo /lib/modules/`uname -r`/build)
>>  KVER := $(shell KDIR=$(KDIR) O=$(O) scripts/get_uts_release.sh)
>>
>> ### PATCH-END
>>
>> It did fix my problem while attempting to build a rpm for drbd 0.8.3 on
>> Fedora Core 7 (with "make rpm")
>>     
>
> it regularly builts in our buildfarm, so I though
> it had been fixed for good...
> but thanks for the heads up.
>
> it is 8.0.x, not 0.8.x, btw...
>   
Yes, I got confused with the numbers...

Thanks for the support

-- 
Maxim Doucet
sys admin @ la maison
http://www.alamaison.fr