[DRBD-user] Re:Problems with drbd syncing

En Chiang Lee ena at india.hp.com
Mon Jun 7 13:14:07 CEST 2004

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.


Hi Lars,

> we are happy to even include youre nodenum, if properly ifdef'ed ...
> 
> I'd already done that, only the drbd.tar on your download site is not
> even zipped, you use printk without severity prefix (what is legal, ok),
> you imported that tree into your own cvs, then modified parts of it, so
> it is difficult to see what exact version you based it on,
> you not even put a diff against the original source in there...
> 
> and your small modifications are not even commented.
> you disable parts of the code, but don't say why.
> you put in an additional branch (e.g. in drbdd_init ) but don't say why,
> what the intention is, why it needs be done exactly there, or what
> "event" this reacts to...

I apologize for the haphazard way that the code has been written. I'll
look at cleaning it up and then hopefully, the properly ifdef'ed and
commented code can be added to your cvs repository.

> I'll mail you with private mail some diff where I think this might be
> your modifications forward ported to current cvs (or my working
> directory, for that matter, so tomorrows cvs). maybe you want to comment
> your modifications, and rather maintain a patchset than a fork.

Thanks. I'll work on this.

En Chiang




More information about the drbd-user mailing list