<br><br><div class="gmail_quote">On Thu, Aug 25, 2011 at 11:06 AM, Philipp Reisner <span dir="ltr"><<a href="mailto:philipp.reisner@linbit.com" target="_blank">philipp.reisner@linbit.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This the first request for review of drbd-8.4. The complete set has<br>
500 patches. In this first series there are only 118 of these.<br>
<br></blockquote></div><br>Lars,<br><br>I've only taken a quick glance, but is drbd functional between applying each patch?<br><br>It doesn't look like it to me, but I didn't look that close. I also saw at least one patch that introduced a new function with no caller to test it.<br>
<br>The idea is that a patch series leave a testable / functional kernel after each patch in the series is applied sequentially.<br>
<br>That is the only way git bisect can do its job.<br><br>ie. Introducing a new function but no new caller makes a change, but there is no way to test it. Therefore there is no real value in not merging that patch with one that has the new call in it.<br>
<br>Greg<br>