[Drbd-dev] request_timer continuous loop if there is disk-timeout

[박경민]

Hello.
I'm a software engineer in Mantech.

In testing about disk-timeout property,
if not default value, which will lead into a continuous loop.

in request_timer_fn()
...
if (device->disk_state[NOW] > D_FAILED) {
et = min_not_zero(et, dt);
next_trigger_time = time_min_in_future(now,
next_trigger_time, oldest_submit_jif + dt);
restart_timer = true;
}
...
I think, if there is no request, next_trigger_time should be calculated
below
next_trigger_time = time_min_in_future(now,
next_trigger_time + *dt*, oldest_submit_jif + dt);

However, I can't be sure.

Thanks

-- 

기술연구소                  Mobile : 010-4762-0519

*박 경 민 차장*              kmpak at mantech.co.kr

서울특별시 성동구 성수일로4길 25 서울숲코오롱디지털타워 12층

Fax : 02-575-4858 / Tel : (02) 2136-6978 (978)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20160311/48962d9d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 16223 bytes
Desc: not available
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20160311/48962d9d/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 4544 bytes
Desc: not available
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20160311/48962d9d/attachment-0003.png>