[Drbd-dev] [PATCH 04/10] drbd: Replace and remove old primitives

Kyle Moffett kyle at moffetthome.net
Fri Sep 23 19:33:45 CEST 2011


Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner at linbit.com> wrote:
> From: Andreas Gruenbacher <agruen at linbit.com>
>
> Signed-off-by: Philipp Reisner <philipp.reisner at linbit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg at linbit.com>
> ---
>  drivers/block/drbd/drbd_int.h      |   45 +----
>  drivers/block/drbd/drbd_main.c     |  502 ++++++++++++++++--------------------
>  drivers/block/drbd/drbd_receiver.c |   86 ++++---
>  drivers/block/drbd/drbd_worker.c   |   24 +-
>  4 files changed, 294 insertions(+), 363 deletions(-)

I'm afraid this commit is waaaaay too large and complicated
to have a one-line commit message.

You should either split this up into more pieces or you should
write a detailed log indicated what this is supposed to be doing
and why it is OK.  (Or both).

Cheers,
Kyle Moffett


More information about the drbd-dev mailing list