[Drbd-dev] drbd uses wrong API for struct bio
philipp.reisner at linbit.com
Mon Jan 24 15:27:03 CET 2005
Am Sonntag, 23. Januar 2005 17:16 schrieb Lars Marowsky-Bree:
> Hi all,
> drbd is a quite bad offender for using bio's on stack or embedded in
> other internal structs instead of the pointer interface.
> The attached patch shows the 'right' way as an example, which was pretty
> easy because I could use Jens' patch for md with minimal modifications ;-)
> However, the other offending code lines are within the transfer log and
> other places, and I'm not sure Philipp wants me to mess around with that.
> Jens, on chip.suse.de:/local/lmb/drbd-07/drbd/ you can find the most recent
> drbd kernel code. Could you look over drbd_compat_wrappers.h line 326ff in
> particular and give me a rough rundown of what's broken? We need to fix
> this by Tuesday latest :-(
Did you tested this patch ?
If yes -> I will commit it to SVN right now...
: Dipl-Ing Philipp Reisner Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria http://www.linbit.com :
More information about the drbd-dev