[Drbd-dev] Re: [DRBD-cvs] r1598 - trunk/user

[Lars Ellenberg]

/ 2004-10-19 12:19:18 +0200
\ Lars Ellenberg:
> > In particular these headers
> > 
> > > +#include <asm/byteorder.h>	/* for the __cpu_to_le64 etc. functions  */
> > > +#include <linux/bitops.h>	/* for the hweight functions  */
> > > +#include <linux/types.h>	/* for the __u32/64 type defs */
> > 
> > _are known to break_ on ia64/ppc64/s390x. I'd be very grateful if you
> > could avoid this.
> 
> hm.
> 
> I just don't want to depend on glib-devel just for some endianness issues.
> rather copy waht is neccessary into our own headers.
> which is not too much, anyways.
> 
> #  linux/bitops.h
> we only care for the hweight functions, which are plain c.
> I don't see where they could break on any arch.
> 
> # linux/types.h
> we only care for the __u32 __u64 type defines.
> ok, we can drop that and just use sys/types.h,
> %s/__u\(.*\)/uint\1_t/
> 
> # asm/byteorder.h
> ok, we can drop that, and use utils.h instead.

nonsense.
that is a nonstandard header, too.
well, then I'd just copy_n_paste together our own endian header?

> konsensfähig?

	lge