[DRBD-cvs] svn commit by phil - r2718 - trunk/drbd - A fix by Simon: Just run into another crash when we get

[drbd-cvs at lists.linbit.com]

Author: phil
Date: 2007-01-29 10:57:23 +0100 (Mon, 29 Jan 2007)
New Revision: 2718

Modified:
   trunk/drbd/drbd_worker.c
Log:
A fix by Simon:

Just run into another crash when we get disk write failures - this is related to 
the other recent problems where we could try to use the activity log after the 
disk is detached - in this case it's an actual crash rather than a BUG() call:

Oops - mdev->bc can be NULL by the time we get here...



Modified: trunk/drbd/drbd_worker.c
===================================================================
--- trunk/drbd/drbd_worker.c	2007-01-29 09:40:23 UTC (rev 2717)
+++ trunk/drbd/drbd_worker.c	2007-01-29 09:57:23 UTC (rev 2718)
@@ -188,7 +188,8 @@
 	 * a "we are diskless" param packet anyways, and the peer
 	 * will then set the FullSync bit in the meta data ...
 	 */
-	D_ASSERT(mdev->bc->dc.on_io_error != PassOn);
+	// NOTE: mdev->bc can be NULL by the time we get here!
+	//D_ASSERT(mdev->bc->dc.on_io_error != PassOn);
 
 	/* the only way this callback is scheduled is from _req_may_be_done,
 	 * when it is done and had a local write error, see comments there */