[DRBD-cvs] svn commit by lars - r2185 - branches/drbd-0.7/drbd - get rid of SLAB_NO_REAP flag, it has been removed from

drbd-cvs at lists.linbit.com drbd-cvs at lists.linbit.com
Fri Apr 28 20:25:49 CEST 2006


I meant to check-in this one as a commit in its own right,
since this is the only functional change of the last two commits.

alloc_ee is called in the receiver on Secondary,
as well as in the receiver on SyncSource which may be Primary.
The suspicion is that the memory subsystem may deadlock here,
even though this is not obviously in the io-path.

> Modified: branches/drbd-0.7/drbd/drbd_receiver.c
> ===================================================================
> --- branches/drbd-0.7/drbd/drbd_receiver.c	2006-04-28 15:58:50 UTC (rev 2184)
> +++ branches/drbd-0.7/drbd/drbd_receiver.c	2006-04-28 16:15:07 UTC (rev 2185)
> @@ -181,7 +181,7 @@
>  	page=alloc_page(mask);
>  	if(!page) return FALSE;
>  
> -	if(!_drbd_alloc_ee(mdev,page,GFP_KERNEL)) {
> +	if(!_drbd_alloc_ee(mdev,page,mask)) {
>  		__free_page(page);
>  		return FALSE;
>  	}
> 

-- 
: Lars Ellenberg                                  Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH            Fax +43-1-8178292-82 :
: Schoenbrunner Str. 244, A-1120 Vienna/Europe   http://www.linbit.com :


More information about the drbd-cvs mailing list