[DRBD-cvs] r1743 - in branches/drbd-0.7: . drbd

[svn at svn.drbd.org]

Author: phil
Date: 2005-01-31 12:19:19 +0100 (Mon, 31 Jan 2005)
New Revision: 1743

Modified:
   branches/drbd-0.7/ChangeLog
   branches/drbd-0.7/drbd.spec.in
   branches/drbd-0.7/drbd/drbd_actlog.c
   branches/drbd-0.7/drbd/drbd_compat_wrappers.h
Log:
No longer leak of BIOs.


Modified: branches/drbd-0.7/ChangeLog
===================================================================
--- branches/drbd-0.7/ChangeLog	2005-01-31 09:20:39 UTC (rev 1742)
+++ branches/drbd-0.7/ChangeLog	2005-01-31 11:19:19 UTC (rev 1743)
@@ -6,9 +6,9 @@
 
 0.7.10 (api:77/proto:74)
 -----
- * 0.7.9 had a memory corruption bug. This time I did
-   the cone_bio() fix myself, and this release is supposed
-   to work with SLES9 SP1, Linux-2.6.11 and Linux-2.6.12.
+ * 0.7.9 had a memory corruption bug and memory leakage (BIOs).
+   This time I did the clone_bio() fix myself, and this release is
+   supposed to work with SLES9 SP1, Linux-2.6.11 and Linux-2.6.12.
 
 0.7.9 (api:77/proto:74)
 -----

Modified: branches/drbd-0.7/drbd/drbd_actlog.c
===================================================================
--- branches/drbd-0.7/drbd/drbd_actlog.c	2005-01-31 09:20:39 UTC (rev 1742)
+++ branches/drbd-0.7/drbd/drbd_actlog.c	2005-01-31 11:19:19 UTC (rev 1743)
@@ -68,8 +68,6 @@
 	struct completion event;
 	int ok;
 
-	bio_get(bio);
-
 	bio->bi_bdev = mdev->md_bdev;
 	bio->bi_sector = sector;
 	bio_add_page(bio, page, size, 0);

Modified: branches/drbd-0.7/drbd/drbd_compat_wrappers.h
===================================================================
--- branches/drbd-0.7/drbd/drbd_compat_wrappers.h	2005-01-31 09:20:39 UTC (rev 1742)
+++ branches/drbd-0.7/drbd/drbd_compat_wrappers.h	2005-01-31 11:19:19 UTC (rev 1743)
@@ -544,7 +544,6 @@
 	struct bio *bio;
 
 	bio = req->private_bio = bio_clone(req->master_bio, GFP_NOIO );
-	bio_get(bio);
 	bio->bi_bdev    = mdev->backing_bdev;
 	bio->bi_private = req;
 	bio->bi_end_io  = drbd_dio_end;
@@ -560,7 +559,6 @@
 	struct bio *bio;
 
 	bio = req->private_bio = bio_clone(req->master_bio, GFP_NOIO );
-	bio_get(bio);
 	bio->bi_bdev    = mdev->backing_bdev;
 	bio->bi_private = req;
 	bio->bi_end_io  = drbd_read_bi_end_io;	// <- only difference

Modified: branches/drbd-0.7/drbd.spec.in
===================================================================
--- branches/drbd-0.7/drbd.spec.in	2005-01-31 09:20:39 UTC (rev 1742)
+++ branches/drbd-0.7/drbd.spec.in	2005-01-31 11:19:19 UTC (rev 1743)
@@ -173,9 +173,9 @@
 %changelog
 * Mon Jan 31 2005 10:17:00 +0200 Philipp Reisner <phil at linbit.com>
 - drbd (0.7.10-1)
- * 0.7.9 had a memory corruption bug. This time I did
-   the cone_bio() fix myself, and this release is supposed
-   to work with SLES9 SP1, Linux-2.6.11 and Linux-2.6.12.
+ * 0.7.9 had a memory corruption bug and memory leakage (BIOs).
+   This time I did the clone_bio() fix myself, and this release is
+   supposed to work with SLES9 SP1, Linux-2.6.11 and Linux-2.6.12.
 
 * Tue Jan 25 2005 11:31:00 +0200 Philipp Reisner <phil at linbit.com>
 - drbd (0.7.9-1)