Hi Lars,<br><br><div style="margin-left:40px">Did you get a chance to review the patch? <br><br>If you see a need for any additions/corrections to be made, then do let me know so that i can work on updating the patch accordingly. <br>
<br></div>Thanks and Regards,<br>Samba<br><br>=======================================================================<br><br><div class="gmail_quote">On Tue, Aug 7, 2012 at 4:42 PM, Lars Ellenberg <span dir="ltr"><<a href="mailto:lars.ellenberg@linbit.com" target="_blank">lars.ellenberg@linbit.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Aug 06, 2012 at 07:13:16PM +0530, Samba wrote:<br>
> Lars,<br>
> I apologise for pushing this one a bit fast but i feel it is better to get<br>
> the issue fixed in the trunk so that we do not have any PRIVATE changes in<br>
> our repository.<br>
><br>
> Further, having the patch committed to the trunk will give assurance the<br>
> fix is code reviewed and tested properly.<br>
><br>
> If you have any suggestions/corrections, then do let me know so that I can<br>
> incorporate those and submit an updated patch.<br>
><br>
> You may also suggest verifying specific test cases in order to ensure<br>
> better test coverage and avoid regression.<br>
><br>
> I really appreciate the fact that you and other commiters put extra efforts<br>
> on top on your normal day-job for making this software available to users<br>
> like us. I do know that it needs passion for the project and commitment for<br>
> open source.<br>
><br>
> I hope you would find some time amidst your busy schedule to review the<br>
> patch and commit it to the trunk.<br>
<br>
</div>I'm finally on vacation, so I may find time tonight to leisurely commit<br>
a few patches ;-)<br>
<div class="im"><br>
<br>
><br>
> Thanks and Regards,<br>
> Samba<br>
><br>
> PS:<br>
> Alternatively, how about inviting review comments from other users in the<br>
> community so that we can offload the efforts to some extent. I can guess<br>
> that many users would be needing a fix for the issue of 'sync failure<br>
> during subdir deletion' so those folks can take this patch and review if<br>
> possible or at least test and verify that it works for them. In this way we<br>
> can build an community over the project and ensure that every patch is<br>
> actually reviewed and tested well before getting committed to the trunk.<br>
<br>
<br>
</div>Additional review is always a nice bonus.<br>
<br>
So if anyone would like to comment, please step forward...<br>
<span class="HOEnZb"><font color="#888888"><br>
Lars<br>
</font></span></blockquote></div><br>