[Csync2] sqlite3 and _FILE_OFFSET_BITS=64 commited

Art -kwaak- van Breemen ard+csync2 at telegraafnet.nl
Fri Jun 20 16:35:36 CEST 2008


On Thu, Jun 19, 2008 at 04:38:06PM +0200, Lars Ellenberg wrote:
> this is now committed as revision 399.
> please, anyone in the position to do so,
> try it and report any observations.

Well, I found a memory leak ;-)
This is a generic one though, and the fix doesn't need an
explanation I guess :-).

http://217.196.41.9/~ard/csync2/00-csync2-svn399-memory-leak.diff

--- trunk.399/daemon.c	2008-06-20 13:52:03.000000000 +0200
+++ trunk.work/daemon.c	2008-06-20 15:55:09.000000000 +0200
@@ -507,7 +507,7 @@
 			break;
 		case A_BYE:
 			for (i=0; i<32; i++)
-				tag[i] = strdup(url_decode(tag[i]));
+				free(tag[i]);
 			conn_printf("OK (cu_later).\n");
 			return;
 		}
@@ -529,7 +529,7 @@
 
 next_cmd:
 		for (i=0; i<32; i++)
-			tag[i] = strdup(url_decode(tag[i]));
+			free(tag[i]);
 	}
 }
 


More information about the Csync2 mailing list